search

Qiskit / qiskit_sphinx_theme

A Sphinx theme and documentation guidelines for Qiskit and Qiskit Ecosystem projects
https://qisk.it/docs-guide
Apache License 2.0
14 stars 29 forks source link

updated links to use sphinx-ext-linkcode to create links #589

Closed melechlapson closed 5 months ago

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

Eric-Arellano commented 5 months ago

Thanks! CI failed because you needed to run tox -e fmt. https://github.com/Qiskit/qiskit_sphinx_theme/pull/590 fixes the other CI issues.

Btw, in case this wasn't clear, we don't want to actually merge this PR. This PR was an experiment to see how the extension works. So don't be alarmed that this doesn't get merged. It still was super helpful to open up. I'm writing up next steps on https://github.com/Qiskit/documentation/issues/517.

Btw one tip for open source work: it's useful in your PR description to give more context about what's going on, like linking to https://github.com/Qiskit/documentation/issues/517.

melechlapson commented 5 months ago

Thanks for the tips. I figured that this wasn't really going to be merged so I didn't add a description or link the issues.

Eric-Arellano commented 5 months ago

This has been implemented in Runtime and Provider, so closing because this experiment did its job. Thanks!