search

Qiskit / qiskit_sphinx_theme

A Sphinx theme and documentation guidelines for Qiskit and Qiskit Ecosystem projects
https://qisk.it/docs-guide
Apache License 2.0
14 stars 29 forks source link

deps: bump furo to 2024.1.29 #594

Closed airwoodix closed 5 months ago

airwoodix commented 5 months ago

Update furo from 2023.8.19 to 2024.1.29. Resolves #567.

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

airwoodix commented 5 months ago

@Eric-Arellano would you have hints whether bumping the version is sufficient? It'd be nice to get a dependency on a non-yanked furo release released, since stricter resolvers, e.g. uv, treat yanked releases as incompatible, making it cumbersome to install qiskit-sphinx-theme (works with an override but is not convenient). Thanks!

Eric-Arellano commented 5 months ago

Hey @airwoodix, pardon the delay on this and thank you for taking the initiative with creating this PR. I appreciate it!

This looks good and you followed the correct process at

https://github.com/Qiskit/qiskit_sphinx_theme/blob/d916732ae221a1cc2fd746aa2d8388f05b05d482/CONTRIBUTING.md?plain=1#L146-L149

We're not ready for a 2.0 release because it makes some breaking changes we haven't finished. So I will make a 1.16 patch release with this cherry-picked.

Eric-Arellano commented 5 months ago

@airwoodix qiskit-sphinx-theme 1.16.1 is released. Thanks again for your help!

airwoodix commented 4 months ago

Thanks for the merge and the extra release! Glad to see that a newer furo release works fine too.