Enable dark mode - Githubissues

Qiskit / qiskit_sphinx_theme

A Sphinx theme and documentation guidelines for Qiskit and Qiskit Ecosystem projects

https://qisk.it/docs-guide

Apache License 2.0

15 stars 29 forks source link

Enable dark mode #613

Closed kevinsung closed 2 months ago

kevinsung commented 3 months ago

Fixes #575.

Replaces the existing Carbon icons with different SVGs that are more easily adapted for dark mode by replacing the fill with "currentColor".

TODO:

[x] Add dark mode screenshot tests
[x] Add more dark mode screenshot tests
[x] Make accent purple
[x] Fix other color issues

Eric-Arellano commented 3 months ago

Consider having the icons change be a dedicated precursor PR.

For dark mode, I think it's plausible we'll want visual regression testing for possibly everything, or at least most of them, in dark mode. That's a big PR, so it's useful to split out "prefactors" (refactors as precursors)

kevinsung commented 3 months ago

@Eric-Arellano PTAL. Jupyter looks bad but I don't know if there's a good way to fix that or if it's within the scope of this PR. Furo suffers from the same issue. See https://github.com/jupyter/jupyter-sphinx/issues/218.

kevinsung commented 3 months ago

CI failure seems unrelated. It's been consistently happening for the past half hour or so though.

 error: nodeenv-creation-failed

× Failed to create a `nodeenv`

gracelindsell commented 2 months ago

@kevinsung this all looks good!