compute maximum bisimulation using Paige-Tarjan's Algorithm

Qiskit / rustworkx

A high performance Python graph library implemented in Rust.

https://www.rustworkx.org

Apache License 2.0

1.05k stars 146 forks source link

Closed sander-hergarten closed 2 months ago

sander-hergarten commented 7 months ago

regarding #1075

CLAassistant commented 7 months ago

All committers have signed the CLA.

sander-hergarten commented 7 months ago

i had some trouble running tox -edocs on my machine. Please let me know if there are any issues with the documentation or release notes

coveralls commented 7 months ago

297 of 309 (96.12%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 95.868%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/bisimulation.rs	294	296	99.32%
src/iterators.rs	0	10	0.0%
<!--	Total:	297	309	96.12%	-->

sander-hergarten commented 7 months ago

As a heads up, when reading "Three Partition Refinement Algorithms", I renamed a lot of the variables.

Blocks of Partition $X$: CoarseBlock
Blocks of Partition $Q$: FineBlock
$C$: queue
$S$: splitter_block Also while the authors say that blocks of $Q$ are contained in blocks of $X$ I interpreted this as the block of $Q$ being a subset of $X$. (I found this confusing so i thought i would mention it)