Qiskit / rustworkx

A high performance Python graph library implemented in Rust.
https://www.rustworkx.org
Apache License 2.0
1.08k stars 148 forks source link

Move dag longest path functions to rustworkx-core. #1192

Closed henryzou50 closed 4 months ago

henryzou50 commented 4 months ago

Attempt to Solve #1168

Summary: We are moving the longest_path function to rustworkx-core. The main implementation will be added to rustworkx-core/src/longest_path.rs, utilizing only Rust generics. The existing src/dag_algo/longest_path.rs will be updated to serve as the Python interface. Since we are retaining this file, updates to src/dag_algo/mod.rs, where the four DAG longest path functions reside, are not necessary.

Details

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9102860038

Details


Totals Coverage Status
Change from base Build 9099749227: 0.005%
Covered Lines: 16725
Relevant Lines: 17340

💛 - Coveralls
henryzou50 commented 4 months ago

@mtreinish thanks for the review and comments! I applied the changes you suggested and it should be ready to go now.