Move `collect_runs()` to rustworkx-core

eliarbel commented 3 months ago

This PR moves collect_runs() functionality to rustworkx-core into rustworkx-core/src/dag_algo.rs. This will be used by collect_runs() in src/dag_algo/mod.rs.

Closes #1199

Tasks:

[x] Read the CONTRIBUTING document
[x] Implement in core, including error handling
[x] Add tests in core
[x] Convert core implementation to return iterator over runs
[x] Use core implementation in rustworkx
[x] Update documentation
[x] Format code

eliarbel commented 3 months ago

@mtreinish this is ready for review now, however CI clippy complains on parts in the code not included in this PR (with error: usage of a legacy numeric constant). Any idea?

mtreinish commented 3 months ago

My guess is that the release of rust 1.79 last week is causing new clippy rules to be run and that's causing the failure. Although I thought we should have everything pinned to the MSRV in CI to avoid this kind of situation.

eliarbel commented 3 months ago

My guess is that the release of rust 1.79 last week is causing new clippy rules to be run and that's causing the failure. Although I thought we should have everything pinned to the MSRV in CI to avoid this kind of situation.

Yes, I was on 1.77. Updating to 1.79 I see those warnings locally as well. I'll wait for it to be resolved.

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9579580062

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

82 of 84 (97.62%) changed or added relevant lines in 2 files are covered.
16 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.03%) to 95.86%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
rustworkx-core/src/dag_algo.rs	68	70	97.14%
<!--	Total:	82	84	97.62%	-->

Files with Coverage Reduction	New Missed Lines	%
src/connectivity/mod.rs	16	96.75%
<!--	Total:	16		-->

Totals
Change from base Build 9565715860:	0.03%
Covered Lines:	17460
Relevant Lines:	18214

💛 - Coveralls

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9603800299

Details

82 of 84 (97.62%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.86%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
rustworkx-core/src/dag_algo.rs	68	70	97.14%
<!--	Total:	82	84	97.62%	-->

Totals
Change from base Build 9589302565:	0.0%
Covered Lines:	17460
Relevant Lines:	18214

Qiskit / rustworkx