Qiskit / rustworkx

A high performance Python graph library implemented in Rust.
https://www.rustworkx.org
Apache License 2.0
1.08k stars 148 forks source link

Remove SciPy as a development dependency #1221

Closed IvanIsCoding closed 3 months ago

IvanIsCoding commented 3 months ago

This PR removes SciPy as a development dependency. Instead of relying on NetworkX's new implementation based on SciPy, this introduced forked code from NetworkX's old pure Python implementation.

I added NetworkX's BSD-3 license at the top of the files. We have already done similar for the visualization module in the past.

Partially motivated by #1220. But it is nice to test the hits and pagerank methods in architectures that previously skipped the test before

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9590028523

Details


Files with Coverage Reduction New Missed Lines %
src/iterators.rs 3 75.15%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 9589302565: -0.02%
Covered Lines: 17410
Relevant Lines: 18165

💛 - Coveralls
coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9620377450

Details


Files with Coverage Reduction New Missed Lines %
src/iterators.rs 3 75.89%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 9620375454: -0.02%
Covered Lines: 17589
Relevant Lines: 18348

💛 - Coveralls