Qiskit / rustworkx

A high performance Python graph library implemented in Rust.
https://www.rustworkx.org
Apache License 2.0
967 stars 140 forks source link

Cleaned up some control flow and optimized some parts. #1241

Closed Larmbs closed 4 days ago

Larmbs commented 5 days ago

This is my second time doing this, forgot to format final result.

I just made some changes to control flow to optimize some parts. The code does the exact same thing but is just shorter and more readable.

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 9767504553

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
rustworkx-core/src/min_scored.rs 0 1 0.0%
<!-- Total: 31 32 96.88% -->
Totals Coverage Status
Change from base Build 9763575829: 0.02%
Covered Lines: 18035
Relevant Lines: 18825

💛 - Coveralls
Larmbs commented 4 days ago

Yeah, I believe the control flow should be identical but it's best not to risk it.

IvanIsCoding commented 4 days ago

Code coverage is 100% and I checked the matches, I think it is good to go

coveralls commented 4 days ago

Pull Request Test Coverage Report for Build 9787794796

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
rustworkx-core/src/min_scored.rs 0 1 0.0%
<!-- Total: 31 32 96.88% -->
Totals Coverage Status
Change from base Build 9763575829: 0.02%
Covered Lines: 18035
Relevant Lines: 18825

💛 - Coveralls