search

Qiskit / rustworkx

A high performance Python graph library implemented in Rust.
https://www.rustworkx.org
Apache License 2.0
1.1k stars 151 forks source link

Move more connected components functions to retworkx-core #602

Open enavarro51 opened 2 years ago

enavarro51 commented 2 years ago

What is the expected enhancement?

595 is in the process of moving connected_components and number_connected_components from retworkx/src/connectivity/conn_components.rs to retworkx-core/src/connectivity/conn_components.rs.

There are a number of other connected component related functions in retworkx/src/connectivity/mod.rs, such as strongly_connected_components, is_connected, and node_connected_component, that could also be moved over to retworkx-core/src/connectivity. The function in mod.rs would then just call the retworkx-core version, similar to what's done with connected_components.

kris524 commented 2 years ago

Hi @enavarro51, Is this issue still relevant? I would like to help as much as I can.

enavarro51 commented 2 years ago

Sure. Any of the functions in retworkx.src.connectivity.mod.rs that are not already in retworkx.retworkx-core.src.connectivity could be moved in a way similar to the way connected_components was done. Let me know if you have any questions about it.

acharyasourav commented 2 years ago

Hey @enavarro51 I would like to work on this. I have read and also got the slightest idea of what needs to be done. Also, I'm unable to find the retworkx-core folder.

kris524 commented 2 years ago

Hi @SUGARXUST thanks for reaching out. If you want you can have a look at my MR and help with testing and adding more stuff

acharyasourav commented 2 years ago

Sure I would like to help @kris524 please mention the request so that I can see what's going on and what can be done by me.

kris524 commented 2 years ago

https://github.com/Qiskit/rustworkx/pull/638