Improving TypeConverter implementation

Qite / Umbraco-Inception

A code first approach for Umbraco (7)

MIT License

26 stars 9 forks source link

Improving TypeConverter implementation #2

Closed JimBobSquarePants closed 10 years ago

JimBobSquarePants commented 10 years ago

The TypeConverters were not correctly implementing the base TypeConverter class.

I've updated them to better match the example implementations on MSDN and tested them briefly. (This project will need proper DB unit testing set up) and they seem to work.

I would recommend that a proper testing mechanism would be set up before releasing new updates though.

nojaf commented 10 years ago

Any suggestions on putting up some tests? I haven't got any experience with unit tests so if you can point me in the right direction...

JimBobSquarePants commented 10 years ago

No worries, I'll see if I can knock something out for you.