search

QiuminGe / cpp-check-lint

MIT License
12 stars 6 forks source link

skip using the --headers flag when no headers are specified #18

Closed heemonsu closed 3 years ago

heemonsu commented 3 years ago

Hey, first of all, thanks for working on this plugin! I have tried other lint plugins, but I like this one because its simple works great for remote sessions with containers as well.

I am trying to use this plugin for setting up a development environment for ROS. I am trying to use a custom cpplint executable which supports checking lint best practices for things specific to ROS code as well. This is the executable that is used by other tools we use for ROS development as well. https://github.com/ros/roslint/blob/0.11.2/src/roslint/cpplint.py#L62

Unfortunately, this executable does not support specifying the --headers flag, so when running lint through this plugin the command fails.

I don't think this breaks any backwards compatibility and the default argument still works as expected. Let me know if the change makes sense, or if there is another simpler way to skip using the --headers flag.

Thanks!

QiuminGe commented 3 years ago

Today I'll submit a version to fix this problem

heemonsu commented 3 years ago

Tried 1.3.5, and its working as expected. Thanks for the quick turn-around!