Closed ImMorpheus closed 7 years ago
Looks neat, although I would have prefered that you made separated pull requests for each fix.
I still do not understand why the system would deny folder creation in .idea or creating the file in the first place. The reason I didn't want to modify the workspace.xml is that in case Idea updates the format, I really didn't want to corrupt their project.
So if I am correct the changeset for this PR is ?:
I don't see a reason why you changes wouldn't work, but atm I don't really have time to test them for myself. Are you 100% sure that everything works fine?
Correct. Sorry about not separating the fixes.
Refactored some awful java code style violations by me (sorry about that).
It was not intentional. Technically I planned to refactor the plugin with the next pull
Yes they work. Obviously I tested them before opening a pull request
This issue (SpongeStart not generating IntelliJ task) was found while trying to fix a problem with spongeforge download
In the log I found
java.nio.file.AccessDeniedException: .idea\runConfigurations\StartForgeServer.xml
Normally configurations are stored in .idea\workspace.xml (unless a directory-based project format is used and the run/debug configs are shared).
Finally gradle was updated, hoping to fix #1 (it didn't work).
Edit:
SpongeStart ignoring forge version is now fixed.