search

Qluxzz / avanza

A Python library for the unofficial Avanza API
https://qluxzz.github.io/avanza/
MIT License
85 stars 40 forks source link

Add endpoint to retrieve existing stop losses #39

Closed fernandobrito closed 2 years ago

fernandobrito commented 2 years ago

Hi! I'm in the process of automating the update of my stop losses on Avanza and the first step in my automation is that I need to check my existing stop losses. Is that something you want to have merged here as well? The next step (another PR later this month) is another endpoint to actually be able to create new stops and delete existing ones.

Thanks for the lib!

Example of a real response using the code from this PR: image

warna720 commented 2 years ago

Does the endpoint accept any parameters/filters? If so, it would be nice to include does as well or at least document them. Besides that, looks good.

fernandobrito commented 2 years ago

Hi @warna720, sorry for the delay!

Thanks for taking a look. From the UI I can't see any filters or interactive elements that would be represented as parameters in this endpoint.

image

Also from the Android app I can't find anything, so to the best of my knowledge, there are no possible parameters.

I've been using this in my pet project for a month and it has been working great.

warna720 commented 2 years ago

LGTM then. @Qluxzz have the last word though

Qluxzz commented 2 years ago

Thank you @warna720 for the code review, and thank you @fernandobrito for contributing!

fernandobrito commented 2 years ago

Amazing, thank you @Qluxzz for the library and the time maintaining it. 👏 . Wish you lots of profits in the market!

Robinhiio commented 1 year ago

@fernandobrito Hi! Did you ever succeeded/continued with functionality for creating new stop losses ?

fernandobrito commented 1 year ago

Hi @Robinhiio. Unfortunately not. I ended up moving away from Avanza to Degiro (when they were still opening new ISK accounts, which they are not doing anymore today).