search

Qluxzz / avanza

A Python library for the unofficial Avanza API
https://qluxzz.github.io/avanza/
MIT License
85 stars 40 forks source link

update chart data path #75

Closed vasba closed 1 year ago

Qluxzz commented 1 year ago

Do the arguments (period and resolution) still work as expected, and does the return model look the same as before?

Otherwise, these need to be updated as well.

vasba commented 1 year ago

The existing periods and resolutions still work but only certain resolutions are available for a given period.

I have updated the returned model.

vasba commented 1 year ago

@AmirEghbali This commit https://github.com/Qluxzz/avanza/commit/ee99bf7048bf7b9353563b1b5f5b5342a14cf23d done by you removed some periods that are needed to this endpoint.

I will have to add back the periods that you removed because I use them.

AmirEghbali commented 1 year ago

Please add them back. When I removed some periods it was because they were not supported in insights_report.

Den tors 22 dec. 2022 20:34vasba @.***> skrev:

@AmirEghbali https://github.com/AmirEghbali This commit ee99bf7 https://github.com/Qluxzz/avanza/commit/ee99bf7048bf7b9353563b1b5f5b5342a14cf23d done by you removed some periods that are needed to this endpoint.

I will have to add back the periods that you removed because I use them.

— Reply to this email directly, view it on GitHub https://github.com/Qluxzz/avanza/pull/75#issuecomment-1363272466, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUD4ZLYY6HKZRUFOZV5JBU3WOSUNHANCNFSM6AAAAAAS7N243M . You are receiving this because you were mentioned.Message ID: @.***>

AmirEghbali commented 1 year ago

This should close #68. Right?

Den tors 22 dec. 2022 20:34vasba @.***> skrev:

@AmirEghbali https://github.com/AmirEghbali This commit ee99bf7 https://github.com/Qluxzz/avanza/commit/ee99bf7048bf7b9353563b1b5f5b5342a14cf23d done by you removed some periods that are needed to this endpoint.

I will have to add back the periods that you removed because I use them.

— Reply to this email directly, view it on GitHub https://github.com/Qluxzz/avanza/pull/75#issuecomment-1363272466, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUD4ZLYY6HKZRUFOZV5JBU3WOSUNHANCNFSM6AAAAAAS7N243M . You are receiving this because you were mentioned.Message ID: @.***>

vasba commented 1 year ago

@AmirEghbali

Yes, it does!

Who can merge this?

Qluxzz commented 1 year ago

Thanks for contributing!