QodotPlugin / Qodot

Quake .map support for Godot 4.2
MIT License
646 stars 53 forks source link

Mend regression in parsing entity string values containing spaces #117

Closed solarbearcub closed 11 months ago

solarbearcub commented 11 months ago

I use entity values for things like signs and some interactable button prompts. I noticed after the transition between C# and GDScript that the parser behaviour has changed:

image

image

I'm not familiar with the format's grammar and found what I think is the source of the bug by tracing back through the control flow manually. It seems that the parsing rules are subtly different and now strings containing spaces are sometimes parsed incorrectly, with extra spaces added and sometimes spaces being snipped out erroneously.

This PR is a small change to the parsing logic that hopefully fixes the issue.

EMBYRDEV commented 11 months ago

Thank you!