search

QodotPlugin / qodot-plugin

(LEGACY) Quake .map support for Godot 3.x
MIT License
960 stars 70 forks source link

Add defaults sections to faceattribs for scale settings Fix #120 #125

Closed Zaraka closed 2 years ago

Zaraka commented 3 years ago

I was dazzled why qodot doesn't use JSON class so I used it as a demonstration

Shfty commented 3 years ago

This isn't idiomatic with the rest of the TB game config, so can't be merged as-is.

A face attribute default should be a resource type (as with surface flags, content flags, etc.) that encodes the possible values it can hold in the final config file using the corresponding Godot types.

The idea being that: A. The user shouldn't be required to know the TB config format in order to configure it from the inspector B. Options should be represented by the approriate control in the inspector (export(Dictionary) should be avoided, since the UI for it is pretty clunky)

Zaraka commented 3 years ago

I've created a new TrenchBroomFaceAttribDefaults Resource with all the attributes I could found over GameConfigParser.cpp in Trenchbroom. Attribute types are defined in Godot format but exported to Trenchbroom format. I have not tested surfaceContents, surfaceFlags, surfaceValue, and color as I'm not sure what they should do.

Zaraka commented 2 years ago

will this ever be merged?