search

QodotPlugin / qodot-plugin

(LEGACY) Quake .map support for Godot 3.x
MIT License
981 stars 72 forks source link

qodot_trenchbroom_config_folder.tres doesn't work unless you have the default "icon.png" in your project #130

Closed JamesC01 closed 3 years ago

JamesC01 commented 3 years ago

qodot_trenchbroom_config_folder.tres doesn't work if you delete icon.png.

Shfty commented 3 years ago

Solution: Don't delete icon.png

JamesC01 commented 3 years ago

Well I know that. Feels more like a workaround than a solution. Why assume you're using icon.png? You could use a custom icon and it could be named something different. Relying on something that may or may not be there is bad in my opinion. There's a perfectly good icon.png for qodot in the qodot folder. Couldn't it fall back to that if it can't find res://icon.png, instead of just erroring?

JamesC01 commented 3 years ago

Hey, could you look into this again? I don't think the plugin should just break if there' no icon.png. If you argue that there should always be an icon, then what about the case where multiple icons are used? I've come across WindowsIcon.png etc. before. And then there's the possibility of different file types. I know it's a small issue to encounter, but it'd probably be a small issue to fix, too.

Ignore what I said in my previous comment, it doesn't need to fall back to the qodot icon. Look at Trenchbroom's docs under "Game Configuration File Syntax" It says that the Icon property is optional. Couldn't qodot just not output the icon property if it can't find an icon? It works fine that way with trenchbroom.