Allow adding the repo as a submodule by moving addons to the root. - Githubissues

QodotPlugin / qodot-plugin

(LEGACY) Quake .map support for Godot 3.x

MIT License

982 stars 72 forks source link

Allow adding the repo as a submodule by moving addons to the root. #146

Open fire opened 2 years ago

fire commented 2 years ago

Hi, any suggestions on this problem?

Context and Problem Statement

Currently I cannot directly add this repo as a submodule into my project.

I want to add this project to the Sunkper Summer Project.

Describe the proposed option and how it helps to overcome the problem or limitation

Move the files to the root.

Describe how your proposal will work, with code, pseudo-code, mock-ups, or diagrams

Go to Gitkraken, move the files so that the files are move to the root.

Like addons/qodot becomes .

Positive Consequences

Able to be git submoduled into the summer project

Negative Consequences

change is hard

Option graveyard:

Option: Keep as is
Rejection Reason: Not sure how to make the submodules work

If this enhancement will not be used often, can it be worked around with a few lines of script?

Is a git technique.

Is there a reason why this should be core and done by us?

Needs to be done by Qodot/qodot-plugin

References

https://github.com/sunkper/Project-Summer-Island

Shfty commented 2 years ago

As far as I'm aware, this is at odds with hosting on the Godot AssetLib; if i move the plugin to the root, it's going to dump itself into res:// whenever someone first adds it to their project, which is not desirable.

I've had similar issues with submodule roots before now, and the best solution I can think of to your issue is adding the repo as a submodule (for the sake of organization, etc), then symlinking its plugin subfolder to res://addons/qodot.