Qolors / FeedCord

A dead simple RSS Feed with Discord Webhooks
MIT License
127 stars 6 forks source link

v1.1.0 - Mismatch in Logging String Placeholders Causes FormatException #1

Closed Qolors closed 10 months ago

Qolors commented 11 months ago

With v1.1.0 there was an introduction to a bug when there is a successful post to Discord:

In the Notifier class within the SendNotificationsAsync method, there are logging statements that have mismatched placeholders. Specifically:

Using a function call (DateTime.Now) as a placeholder name:

logger.LogError("[{DateTime.Now}]: Payload Service returned null after attempting to build", DateTime.Now);

Using two placeholders but providing only one argument:

logger.LogInformation("[{DateTime.Now}]: Response - Successful: Posted new content to Discord Text Channel at {CurrentTime}", DateTime.Now);

Suggested Fix:

Correct the placeholders to match the provided arguments, ensuring consistent naming and number of arguments for each logging statement in the Notifier class.

Qolors commented 10 months ago

this issue has been handled in the v1.2.0 release - https://github.com/Qolors/FeedCord/releases/tag/v1.2.0