Qonstrukt / helm-charts

Helm Charts for several projects.
4 stars 4 forks source link

[UniFi] Add support for a service type #3

Closed rafaelperoco closed 12 months ago

rafaelperoco commented 12 months ago

Helm Chart Service Type

Summary

This PR adds a new service.type value to the Helm chart. This value can be used to specify the type of service to be used for the service resource in the Helm chart.

Motivation

The current Helm chart uses a service.type value of LoadBalancer for the service resource. This is not always desirable, as it requires the cluster to have a load balancer available. This is not always the case, for example when using a local Kubernetes cluster such as Minikube or k3s.

Qonstrukt commented 12 months ago

I see the value was actually only missing from the service definition, thanks!

As a good practice though, you should always use a LoadBalancer, even on single node k3s clusters, because it makes your setup portable, and allows you to expand to more nodes later, even if it's just for testing. I do the same thing with my own single node k3s cluster, and it came for free during initialisation. 😉 But nonetheless, handy to have a working type setting. 🙂

Can you also update the changelog in the Chart definition? So just replace the single line in artifacthub.io/changes with something like: "Add support for a service type"

rafaelperoco commented 12 months ago

@Qonstrukt, in my setup, I'm employing K3s, which uses ingress-nginx as a Load Balancer. MetalLB is also in play, facilitating routing to the internal network. The flow is structured as follows:

User > Network > MetalLB > Ingress-Nginx > unifi-controller service > pod

Qonstrukt commented 12 months ago

Makes sense, I have the same. Thanks for your contribution!