Minor fixes to log4j: better log name, use unix carriage returns

Qoracoin / Qora

Public GIT for the Qora cryptocurrency project.

http://qora.org

Other

43 stars 24 forks source link

Minor fixes to log4j: better log name, use unix carriage returns #94

Closed DaveWK closed 3 years ago

DaveWK commented 6 years ago

added some minor fixes; the file's endlines all had "^M" -- logfile names usually end with .log

catbref commented 6 years ago

Does removing the Windows carriage returns (^M) break log4j2 on Windows though? Renaming the log filenames from log.txt.1 to qora.log.1 might be beneficial though. I'll raise this PR in dev channel

DaveWK commented 6 years ago

this shouldn't break windows editors; they will interpret the unix-style endings and convert, as should text editors. the issue is when trying to run the packaged binary on a linux server it will break due to the "^M"

DaveWK commented 5 years ago

@catbref any interest in the dev channel? this would make the zips for linux a lot cleaner..