Qoracoin / Qora

Public GIT for the Qora cryptocurrency project.
http://qora.org
Other
43 stars 24 forks source link

ConnectionCreator and ConnectionAcceptor don't shutdown smoothly #98

Closed catbref closed 5 years ago

catbref commented 6 years ago

On shutdown the ConnectionCreator doesn't exit swiftly and users might see this error message:

Exception in thread "Thread-24" java.lang.IllegalAccessError: DB has been closed
        at org.mapdb.EngineWrapper.checkClosed(EngineWrapper.java:155)
        at org.mapdb.Caches$HashTable.get(Caches.java:238)
        at org.mapdb.BTreeMap.get(BTreeMap.java:595)
        at org.mapdb.BTreeMap.containsKey(BTreeMap.java:1506)
        at database.PeerMap.getInfo(PeerMap.java:419)
        at database.PeerMap.isBlacklisted(PeerMap.java:427)
        at network.PeerManager.isBlacklisted(PeerManager.java:71)
        at network.ConnectionCreator.run(ConnectionCreator.java:102)

In addition, there doesn't seem to be any short-cut exit in ConnectionAcceptor if a new connection arrives during shutdown.

catbref commented 6 years ago

Should be fixed in v0.26.10