Change ambiguous method and parameter names, driveby clippy fixes

Qovery / RedisLess

RedisLess is a fast, lightweight, embedded and scalable in-memory Key/Value store library compatible with the Redis API.

MIT License

150 stars 16 forks source link

Change ambiguous method and parameter names, driveby clippy fixes #31

Closed clarity0 closed 3 years ago

clarity0 commented 3 years ago

Also removed redundant setex storage trait method

evoxmusic commented 3 years ago

Your changes looks great. Especially for Storage trait. It didn't make sense to have 1:1 implem with Redis command. It's supposed to mimic disk operations. I'll take a look deeper once I am in front my computer :) (phone review haha)

evoxmusic commented 3 years ago

Is it ready to be merged @clarity0 ?

clarity0 commented 3 years ago

Is it ready to be merged @clarity0 ?

yeah