draft: add TYPE command

[tbmreza]

How do you test a new command? I'm not sure if I'm already on the right direction, i.e., if I only need to figure out what to feed send_packed_command() with, and how to receive the connection's response.

28

[evoxmusic]

If a command is not available via the Redis Rust client you can use send_packed_command(...) - is it correct @clarity0? I didn't have the time to try this command since I am working on the raft implementation

[clarity0]

@tbmreza I havent tested it out extensively but according to the redis-rs docs changes the state of the connection or something, and my test for the GETDEL command only behaved as expected when I called get twice. I just gave up testing that out because no Redis client I've seen implements GETDEL and it's deprecated apparently. see my comment here

[clarity0]

I think the python redis client does implement TYPE unlike redis-rs. You could test it out with that, because send_packed_command just ignores the response from the server.

[clarity0]

Does it work well with the python client?

[tbmreza]

Does it work well with the python client?

Should I test it thoroughly? If so, do I put them (SET and TYPE commands for every DataType) all in main.py? @clarity0

[tbmreza]

for the 1 TYPE command I tested in python client, yes it works well (the assertion doesn't fail)

[clarity0]

Right now there is only support commands that add strings so you can't really test the other cases with a client but they should work fine.

[evoxmusic]

@clarity0 @tbmreza good to be merged?

[evoxmusic]

@tbmreza can you rebase?

[tbmreza]

@tbmreza can you rebase?

sure but I'm not a capable git user. could you tell me how to do it, step by step?

[tbmreza]

I'm closing this PR. Currently looking at other good first issues (#23 if it doesn't turn out to be too hard for me), will open new PR covering that and #28. Thanks for bearing with me!