search

Qovery / Replibyte

Seed your development database with real data ⚡️
https://www.replibyte.com
GNU General Public License v3.0
4.18k stars 129 forks source link

Release v0.8.1 #130

Closed evoxmusic closed 2 years ago

evoxmusic commented 2 years ago

Signed-off-by: Romaric Philogène rphilogene@qovery.com

cc @fabriceclementz 👍🏽

evoxmusic commented 2 years ago

Argh, the update as commit some files that I didn't want to commit 😂 - I need to revert those changes

fabriceclementz commented 2 years ago

@evoxmusic I'm not sure why there is already a 0.8.1 release here https://github.com/Qovery/Replibyte/releases/tag/v0.8.1 as the PR isn't merged ?

evoxmusic commented 2 years ago

Not sure as well what happened. What I did is:

  1. I've been in the main branch
  2. I executed the script ./release.sh 0.7.3 0.8.1
  3. That's it.

Did I miss something?

fabriceclementz commented 2 years ago

No, it's all good. I will retry it on a fake repo

fabriceclementz commented 2 years ago

I understood what happened. It's necessary to wait for the PR is merged before validating the last step of the release script. You can see how this final step works here: https://github.com/Qovery/Replibyte/blob/main/release.sh#L70 After you merge the PR, it will create properly the Release by running:

git checkout main
git pull
git tag -a -m"Release v${new}" "v${new}"
git push --tags

If we don't wait before the PR is merged, it will use the current state of main without the version bump.