Qovery / Replibyte

Seed your development database with real data ⚡️
https://www.replibyte.com
GNU General Public License v3.0
4.18k stars 129 forks source link

feat: atlas support #154

Closed jamesloosli closed 2 years ago

jamesloosli commented 2 years ago

This PR has a few changes, but includes primarily the functionality to pass the mongo URI directly to mongosh and mongodump/mongorestore.

This also includes moving from mongo to mongosh, as the former is deprecated.

Should resolve issue #135

evoxmusic commented 2 years ago

Hi @jamesloosli , thanks for your first contrib 👏🏽 I put @benny-n in the loop since he worked on the MongoDB connectors.

benny-n commented 2 years ago

This also includes moving from mongo to mongosh, as the former is deprecated.

@jamesloosli Are you sure about this? Many of the MongoDB docs I've seen include the use of mongo binary (not mongosh).

Other than that, the changes look good 👍

jamesloosli commented 2 years ago

I was basing that decision on the output from the mongo client itself;

❯ mongo
MongoDB shell version v5.0.0
connecting to: mongodb://127.0.0.1:27017/?compressors=disabled&gssapiServiceName=mongodb
Implicit session: session { "id" : UUID("51fa6ec8-c9f1-4008-8386-5f51c6113e3f") }
MongoDB server version: 5.0.8
================
Warning: the "mongo" shell has been superseded by "mongosh",
which delivers improved usability and compatibility.The "mongo" shell has been deprecated and will be removed in
an upcoming release.
We recommend you begin using "mongosh".
For installation instructions, see
https://docs.mongodb.com/mongodb-shell/install/
================

which then led me to this. I then checked where mongo was being used, and it was only the function that was checking if the connection was live. mongodump and mongorestore seem to be doing the actual work.

benny-n commented 2 years ago

@jamesloosli Ok, LGTM 👍