Qovery / Replibyte

Seed your development database with real data ⚡️
https://www.replibyte.com
GNU General Public License v3.0
4.18k stars 129 forks source link

Error on dump: "Unterminated string literal" #166

Closed eswarty closed 2 years ago

eswarty commented 2 years ago

Hi, I'm using replibyte with Postgres and GCP. When I run replibyte dump create, the script panics with the error:

thread 'main' panicked at 'TokenizerError { message: "Unterminated string literal", line: 9, col: 64 }', dump-parser/src/postgres/mod.rs:761:13

I previously saw this issue before, but it was fixed here: https://github.com/Qovery/Replibyte/issues/94. I was able to create a dump after that, but now I'm seeing the error again.

Happy to provide the specific failing query over email!

evoxmusic commented 2 years ago

Hi @ederski , to be sure it's (or not) a regression, can you share with me the part of your dump that is failing here?

eswarty commented 2 years ago

@evoxmusic Sent you a DM :)

evoxmusic commented 2 years ago

HI @ederski , I looked at your query failing and it is another query that is failing to be correctly parsed by our Tokenizer. I am going. to try to reproduce it and provide a fix. I keep you posted

evoxmusic commented 2 years ago

@ederski I dm'ed you on Discord :)

evoxmusic commented 2 years ago

Hi @ederski , I've tried today to reproduce the issue with the 2 queries that you shared to me and no luck. It's working perfectly fine. Can you try to create a full dump with synthetic data to reproduce the bug? There is probably a succession of special characters making leading to this TokenizerError :(

evoxmusic commented 2 years ago

Hi @ederski , please re-open this issue if you still have the problem with the latest version. Thank you