search

Qovery / Replibyte

Seed your development database with real data ⚡️
https://www.replibyte.com
GNU General Public License v3.0
4.16k stars 128 forks source link

AWS Cross Account S3 Buckets #233

Open gugacavalieri opened 2 years ago

gugacavalieri commented 2 years ago

First of all, congrats for the project. It's awesome how fast it runs and how simple is to setup everything!

I think this actually broke AWS Cross account functionality (PR: https://github.com/Qovery/Replibyte/pull/212). I am trying to store the dumps on a S3 bucket in another account.

When you use list_buckets the S3 Client won't return the buckets from another account. Do you remember why get_bucket_accelerate_configuration was breaking at first place?

Also the list_buckets operation requires s3:ListAllMyBuckets on the s3:* account level not on a bucket level so maybe switching to the list_bucket operation to list the files inside of a S3 bucket would also improve the security in terms of policy.

Let me know how I can help!

PS. Just tested with v0.9.6 and I am able to write/access the dumps to a S3 bucket in another account.

evoxmusic commented 2 years ago

Hi @gugacavalieri , since I don't have so much time those days. Do you think you can provide a fix? Thank you for your help

gugacavalieri commented 2 years ago

Hi @evoxmusic. Sure, I will try to get a fix in the next weeks and let you know! Glad to help!