Qovery / engine

The Orchestration Engine To Deliver Self-Service Infrastructure ⚡️
https://www.qovery.com
GNU General Public License v3.0
2.27k stars 68 forks source link

add termination_grace_period_seconds advanced setting #731

Closed kwigley closed 1 year ago

kwigley commented 1 year ago

just wanted to get my hands on the engine codebase, please close if not accepting contributions

benjaminch commented 1 year ago

Hello @kwigley,

Thanks a lot for this nice contribution :)

This is definitively something we want to integrate into the Engine. In order to proceed, we will need just a bit of time mainly for the following reasons:

  1. This repo is a mirror, so we need to cherry-pick your commit and apply it to the root repo
  2. We need to add the "plumbing" work to integrate this feature into our product (API + frontend)

I am adding this to our internal backlog :)

Thanks again for your contribution, very much appreciated !

kwigley commented 1 year ago

sounds good @benjaminch! thank you 👍

deimosfr commented 1 year ago

Sorry for the delay and thanks for the PR. It will be merged in the coming days

acarranoqovery commented 1 year ago

Hi @kwigley , this has been released. thanks for your PR! https://hub.qovery.com/docs/using-qovery/configuration/advanced-settings/#deploymenttermination_grace_period_seconds