search

Qovery / scaleway-api-rs

Rust lib for Scaleway API
GNU General Public License v3.0
9 stars 1 forks source link

Change number binding to i64 #17

Closed gaetronik closed 2 years ago

gaetronik commented 2 years ago

A the moment, openapi number type maps to f32 which leads to json sent to the api with number as 0.0 for example. The scaleway api does not work with float and throw 400 errors, at least for domain API This PR changes the binding to i64 which leads to proper output.

I just changed the script not pushed all the changes

evoxmusic commented 2 years ago

Hi @gaetronik , thanks for the PR, someone from our team will handle it

benjaminch commented 2 years ago

Thanks a lot @gaetronik :)

gaetronik commented 2 years ago

I ran into an issue while regenerating rust files, filled a PR at https://github.com/OpenAPITools/openapi-generator/pull/12485

benjaminch commented 2 years ago

Whaoo, thank, I was about to open an Issue as well, thanks a lot !

gaetronik commented 2 years ago

Do you want me to push updated code using my fix for openapi-generator ?

benjaminch commented 2 years ago

Please do, so we can try :)

I would hold a bit until your fix has been merged so it's reproducible for everyone just in case.