search

Qqwy / elixir-type_check

TypeCheck: Fast and flexible runtime type-checking for your Elixir projects.
MIT License
517 stars 25 forks source link

Elixir 1.14 compatibility #150

Closed marcandre closed 1 year ago

marcandre commented 1 year ago

Hi! I was curious to try this on our codebase but ran into issues as we're already using Elixir 1.14

This fixes the two incompatibilities with Elixir 1.14:

It also resolves an issue when running the tests by disabling async mode for the parser tests.

~It also includes #144 (typo in commit message fixed)~ Ah! Already merged 👍

marcandre commented 1 year ago

I bumped the github action too, but the tests don't seem to be running...

Qqwy commented 1 year ago

Very strange, let me investigate.

Qqwy commented 1 year ago

It seems like the workflow is not running as a security measure. See this doc page from GitHub. However, I cannot find the 'Approve and run' button that should be visible to start the workflow run manually.

marcandre commented 1 year ago

It seems like the workflow is not running as a security measure. See this doc page from GitHub. However, I cannot find the 'Approve and run' button that should be visible to start the workflow run manually.

Yeah, I was looking for that too.

Let me try removing the commit that changes the github action

marcandre commented 1 year ago

Doesn't show the usual message "CI will run after approval from someone higher in the food chain for this project" or whatever usually shows 🤷‍♂️

Qqwy commented 1 year ago

:shrug: Then I assume that GitHub has problems right now. I will run the tests of this PR on Elixir v1.14 and v1.13 locally.

Please let me know if you're happy with the changes as they are now, or whether I should wait before merging.

marcandre commented 1 year ago

Please let me know if you're happy with the changes as they are now, or whether I should wait before merging.

Ah ah, yeah, that will hopefully teach me not to get cute after creating a PR and screwing things up.

So code should be good now, all green in 1.13.4 ad 1.14.1 (on my machine)

BTW, the sync code doesn't take long... "Finished in 37.4 seconds (34.4s async, 3.0s sync)"

Qqwy commented 1 year ago

Ah ah, yeah, that will hopefully teach me not to get cute after creating a PR and screwing things up.

No worries! :stuck_out_tongue_winking_eye:

Since a few months, GitHub has the possibility to switch PRs between 'draft' and 'ready' mode by the way.

Qqwy commented 1 year ago

Tests are also green here; merging

marcandre commented 1 year ago

@Qqwy Will you be making a release?

Qqwy commented 1 year ago

Yes! I wanted to wait for the CI on master to finish first, just to be sure :wink: .

Version 0.12.3 has been released which contains this PR.

marcandre commented 1 year ago

Awesome, thanks @Qqwy ❤️