Qrome / marquee-scroller

Marquee Scroller Clock News Weather and More
https://www.thingiverse.com/thing:2867294
MIT License
331 stars 158 forks source link

£ sign does not display #155

Open brianmiller1956 opened 4 years ago

brianmiller1956 commented 4 years ago

I have built 3 of these, I can only say well done,a fantastic effort, the £ sign will not display in either the news headlines or the message scroller, it displays something that is much too wide, also I have one running on a 6 module display, it works well, the wide clock displays very nicely but obviously the option to show temperature doesn't work. This doesn't bother me, I changed the 4 entries from =>8 panels to 6 and the wide clock works. Many thanks

victor7376 commented 3 years ago

Not sure if it will work or not, but you could try adding the following line at the end of the marquee.ino file

decodedMsg.replace("%A3", "£");

brianmiller1956 commented 3 years ago

Hi, Thanks for the reply, I did manage to create a workaround for this problem, I first found that the £ sign can be in 2 different locations in the ascii table, what the scroller is doing when it comes across the £ sign is it prints 2 characters, the first is a vertical line with one dot and the second is the character in the second location for the £ symbol in the font file which is a letter U with two dots, my solution was to put the £ font data into both £ sign locations in the font file and to zero out the data for the vertical line with dot character, my scroller now prints a space followed by the £ sign, not a perfect solution but it looks tons better than before. I have tried your suggestion and it looks the same as with my solution, space and then £ sign, so not sure if this is actually working or not. The euro symbol also has a similar problem but you tend not to see this used very often. Hope this helps Brian.

Sent from my iPad Pro

On 6 Jan 2021, at 20:20, victor7376 notifications@github.com wrote:

 Not sure if it will work or not, but you could try adding the following line at the end of the marquee.ino file

decodedMsg.replace("%A3", "£");

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

victor7376 commented 3 years ago

If it’s showing the correct sign it’ll be working, for the euro just add

decodedMsg.replace("%80", "€");

I have been playing around with the code and was able to change the clock wide from clock and city temp to clock and octoprint progess. I’m looking at going for an even bigger display lol.

brianmiller1956 commented 3 years ago

Hi, it was showing the correct symbol with my modification before I tried yours, to verify it fully I would need to reverse my modification, with your modification it is printing 2 characters, “space then £ sign” instead of just the £ sign. I will try your euro mod in the morning. Many thanks

Sent from my iPad Pro

On 6 Jan 2021, at 21:48, victor7376 notifications@github.com wrote:  If it’s showing the correct sign it’ll be working, for the euro just add

decodedMsg.replace("%80", "€");

I have been playing around with the code and was able to change the clock wide from clock and city temp to clock and octoprint progess. I’m looking at going for an even bigger display lol.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

brianmiller1956 commented 3 years ago

Hi I decided to try the euro mod, it doesn’t work it still prints 3 characters which look like the pi symbol and two others, just the same as before, I am testing it by putting € symbols into the box for the scrolling text message on the web configuration page.

Sent from my iPad Pro

On 6 Jan 2021, at 21:48, victor7376 notifications@github.com wrote:

 If it’s showing the correct sign it’ll be working, for the euro just add

decodedMsg.replace("%80", "€");

I have been playing around with the code and was able to change the clock wide from clock and city temp to clock and octoprint progess. I’m looking at going for an even bigger display lol.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

victor7376 commented 3 years ago

I've just been trying the coding and it seems your solution is the only one that works unless someone else can provide it.

brianmiller1956 commented 3 years ago

Hi, Thankyou for letting me know, the way I tested this was to put a row of £ signs into the scrolling message box, I did the same with the € symbol this actually shows 3 characters the pi symbol, e with accent and one quarter symbol. My fix is really a bodge that gets round the £ problem. I am a newcomer to arduino having managed to avoid writing software for all my life, though I have been in electronics and computing for all my life. I now quite enjoy modifying other peoples code to suit my needs, this Marquee Scroller is a fantastic example of well designed software that readily accepts modification without throwing the teddy out every time. Many Thanks.

Sent from my iPad Pro

On 7 Jan 2021, at 12:47, victor7376 notifications@github.com wrote:

 I've just been trying the coding and it seems your solution is the only one that works unless someone else can provide it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

victor7376 commented 3 years ago

I'm the same, very new to arduino. I normally just look at code test to see if a change works and celebrate when it does. If I cant figure it out and cant get any help I just leave it on a trash pile lol.

This scroller is amazing and glad the guy uploaded it for others, I've been trying to get it to work with another API but no luck as the site I'm trying to work with seems to find it funny to name each section the same.

I'm more of a designer / modder than a coder. I have modified the code as I only need time, weather and octoprint. I did try and modify the code to show how long was left on my 3D printer but got the results it seems in seconds as I dont think Qrome coded the hours & minutes into octoprint coding, but it did give me a laugh.

victor7376 commented 3 years ago

Just had a quick look through the code and interestingly I seemed to of stumbled across the library that may contain the error you've discovered. Its within the Adafruit-GFX-Library as this has its own Font's database which contains the £ & €.

uint8_t TomThumbBitmaps

brianmiller1956 commented 3 years ago

Hi, yes it is the glcdfont.H within the adafruit gfx library that I have been modifying, I think that some of the problems are down to whatever ascii standard the file should adhere to not being correct (Sorry adafruit) I have done about 20 mods to the font file to tidy up some of the numbers and lower case letters to improve the look of the display when scrolling. The slight disadvantage is that when the library is updated I have to copy off the edited file and replace it after update. My latest mod on the scroller was to add the year display, funnily I did it on New Year’s Eve so it got a proper test. I would like to add what I believe is called the ordinal suffix! It is the st after 1 the nd after 2 and rd after 3, most of the month is th,

Sent from my iPad Pro

On 7 Jan 2021, at 14:12, victor7376 notifications@github.com wrote:

 Just had a quick look through the code and interestingly I seemed to of stumbled across the library that may contain the error you've discovered. Its within the Adafruit-GFX-Library as this has its own Font's database which contains the £ & €.

uint8_t TomThumbBitmaps

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

victor7376 commented 3 years ago

You're not the only one that would like the 'st, nd &G rd' within the date lol. I did look at it last week but decided it was giving my head a brain f*rt lol, just had a quick look at the code and I cant see how to get year as I think the code is retrieving the time and date via unix which I have no clue lol.

brianmiller1956 commented 3 years ago

if (SHOW_DATE) { msg += TimeDB.getDayName() + ", " + day() ;// now shows day name, number, also added comma to day name msg += TimeDB.getMonthName() + ", " + year() +": ";// moved day to previous line, added comma after month name, added year display and colon }

Hi this is the part of the loop that determines the data order and what is printed, it is about line 387 i reordered the display to display it slightly differently but adding the year is easy. No other changes are needed. Try it and see.

Sent from Mail for Windows 10

From: victor7376 Sent: 07 January 2021 15:53 To: Qrome/marquee-scroller Cc: brianmiller1956; Author Subject: Re: [Qrome/marquee-scroller] £ sign does not display (#155)

You're not the only one that would like the 'st, nd &G rd' within the date lol. I did look at it last week but decided it was giving my head a brain f*rt lol, just had a quick look at the code and I cant see how to get year as I think the code is retrieving the time and date via unix which I have no clue lol. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

victor7376 commented 3 years ago

'smacks palm against head' (Homer)

I was thinking it was going to be a little more complicated than that lol

The last couple of times I've asked regarding code for arduino, I've received replies of 'learn how to use arduino before modifying others code' - thats from the official forum lol.

The code works perfectly btw ;)

Tomorrow I should have some more displays arriving and I'm going to try and make a clock 2 displays high and 4 across. I've already modified Qromes double wide casing. Just need to wait for them to arrive then do some soldering, add some jumper wires and then alter the code on horizontal & vertical.

Cheers btw ;)

brianmiller1956 commented 3 years ago

Yes it is remarkably simple to add the year, I have two clocks using 6 modules as I already had them they work well and one with 8, I tried red and blue leds, they were great, green leds were very poor brightness, the best were white, I got them from Aliexpress Good luck with the new display, let me know if it fills the whole 8 panels, I think I tried double height but it centred the display between the modules, I think you need to use the double height font file.

Sent from my iPad Pro

On 7 Jan 2021, at 20:18, victor7376 notifications@github.com wrote:

 'smacks palm against head' (Homer)

I was thinking it was going to be a little more complicated than that lol

The last couple of times I've asked regarding code for arduino, I've received replies of 'learn how to use arduino before modifying others code' - thats from the official forum lol.

The code works perfectly btw ;)

Tomorrow I should have some more displays arriving and I'm going to try and make a clock 2 displays high and 4 across. I've already modified Qromes double wide casing. Just need to wait for them to arrive then do some soldering, add some jumper wires and then alter the code on horizontal & vertical.

Cheers btw ;)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

victor7376 commented 3 years ago

Looks like theres limits within the code for the diplays.

Hooked up 6 displays (2 vertical x 12 horizontal) - works, but puts time on top line and doent fill - which is where you said double height font will be needed. When it starts to scroll it puts everything in the middle of the two.

Hooking up more than 6 displays just throws up garbage as it seems it cant handle more than 24 (8x8 panels).

I've also discovered that the code is using the old Arduino Json version 5 and not the up to date version 6 & the requesting data from API's is not using the secure requests - I guess this part will be because you would need to update the secure database when websites update their certificates etc,

victor7376 commented 3 years ago

I've overcome the limit of 20 displays, got 28 displays working by using the fixed code from:

https://github.com/vortigont/arduino-Max72xxPanel/tree/54a4a8502678367b36da5ab6207438c2e2f9208b

Just have to download and put in the same folder as the marquee files and change the settings file from:

include to #include Max72xxPanel.h"

The downloaded zip comes with cpp and h files, so when you open marquee.ino you'll have all the bitcoin, weather, octoprint, pi, news and two new files max72xxpanel.

Then just edit the settings file to state how many panels you have connected. I did however use jumpers between the displays instead of wires and it gives a better connection if you dont want to solder between the displays.

victor7376 commented 3 years ago

Confirmed working modes as follows:

1 x 24 works = 1x4 x6 displays

2 x 4 works 2 x 8 works 2 x 12 works

brianmiller1956 commented 3 years ago

Hi, what does the double height display look like? Does it fill the whole display or just centre the same height text. I have some spare displays, might try it out if it looks good. I only use Time, date, weather, and news

My latest mod is to zeropad the hour digit in 24hr mode only, early testing looks good

Sent from my iPad Pro

On 11 Jan 2021, at 19:52, victor7376 notifications@github.com wrote:

 Confirmed working modes as follows:

1 x 24 works = 1x4 x6 displays

2 x 4 works 2 x 8 works 2 x 12 works

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

victor7376 commented 3 years ago

Double height splits the scrolling text into the middle of the displays then the clock goes on the top line.

Would be nice to fill the displays with bigger text, but I aint figured that one out yet lol.

I'm only using date, time and Octoprint,, now with the longer / bigger displays I've added the seconds within the time lol.

I was going to try and figure out the 'estimatedtime' for octoprint as at the moment it shows it up in seconds O.o, but I'm just mainly printing out the double height case, then try and figure out the longer display case.

brianmiller1956 commented 3 years ago

I wondered what the purpose of the double height display was, maybe it’s a feature that wasn’t fully implemented? Like the buzzer pin?

Sent from my iPad Pro

On 11 Jan 2021, at 20:25, victor7376 notifications@github.com wrote:

 Double height splits the scrolling text into the middle of the displays then the clock goes on the top line.

Would be nice to fill the displays with bigger text, but I aint figured that one out yet lol.

I'm only using date, time and Octoprint,, now with the longer / bigger displays I've added the seconds within the time lol.

I was going to try and figure out the 'estimatedtime' for octoprint as at the moment it shows it up in seconds O.o, but I'm just mainly printing out the double height case, then try and figure out the longer display case.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

victor7376 commented 3 years ago

Not sure, but seems he got to a point where it was more hassle than anything, but would of been great to have the double height feature. It seemed a lot of people gave up when Json 6 was released as you have to update your code to different specs for them to work, more than likely thats why he included version 5 in this release.

brianmiller1956 commented 3 years ago

Did you notice that the Temperature in the scrolling display never went below zero last night whilst the temperature in the web interface did go below zero?

Sent from my iPad Pro

On 11 Jan 2021, at 20:45, victor7376 notifications@github.com wrote:

 Not sure, but seems he got to a point where it was more hassle than anything, but would of been great to have the double height feature. It seemed a lot of people gave up when Json 6 was released as you have to update your code to different specs for them to work, more than likely thats why he included version 5 in this release.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

victor7376 commented 3 years ago

Unfortunately I have my clock turned off as I’ve been trying different ways of the displays etc, but strange for that to happen unless it’s a bug in the code.

brianmiller1956 commented 3 years ago

I did sort it out, Line. 381 remove’ Rounded’ from the get temp call, it now shows negative temps and shows the temp to two decimal places. I don’t think it affects any other temperature displays as this is how the scrolling display is assembled.

Sent from my iPad Pro

On 16 Jan 2021, at 19:57, victor7376 notifications@github.com wrote:

 Unfortunately I have my clock turned off as I’ve been trying different ways of the displays etc, but strange for that to happen unless it’s a bug in the code.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

victor7376 commented 3 years ago

Thanks, mines at line 389 due to altering the code, plus I was trying to convert the code to JSON v6, but ran into loads off issues.

victor7376 commented 3 years ago

Just to let you know, I've found another clock like this one, but its updated to use json v6 and also has spotify access with https requests that requires a sites fingerprint (certificate copied from the site you're accessing. Might be interesting to compare them both - Tobers_Multidisplay

brianmiller1956 commented 3 years ago

Looks interesting especially the graphics, by the way your email trail has opened on multidisplay? Not sure how.

Sent from my iPad Pro

On 19 Jan 2021, at 11:50, victor7376 notifications@github.com wrote:

 Just to let you know, I've found another clock like this one, but its updated to use json v6 and also has spotify access with https requests that requires a sits fingerprint (certificate copied from the site you're accessing. Might be interesting to compare them both - Tobers_Multidisplay

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

victor7376 commented 3 years ago

probably because I replied to someone on there regarding their issue as the guy has modified the wifi manager for his project and you need to use it for it to 'work'. But even after following the guys hints for which libraries and which board to use I'm still getting loads of errors in compiling lol.

victor7376 commented 3 years ago

Took a lot to get the d1 mini programmed for the other clock, but it’s working and there seems to be a lot more within the coding with animation. You have to upgrade the 8266 core ( 2.6.3 or V 2.7.1 - 2.6.3 works for me) and overwrite the WiFi manager (his version of the WiFi manager)

victor7376 commented 3 years ago

Not sure if this will help you, but I've come across a clock that has the 'st, nd & rd' for the date numbers.

https://www.adrian-smith31.co.uk/blog/2020/04/dual-colour-animated-clock-using-16x32-bi-colour-matrix/

//then work out date 2 letter suffix - eg st, nd, rd, th etc char suffix[4][3]={ "st", "nd", "rd", "th" }; byte s = 3; if(date == 1 || date == 21 || date == 31) { s = 0; } else if (date == 2 || date == 22) { s = 1; } else if (date == 3 || date == 23) { s = 2; }

Hope it helps you in figuring out how to code it lol.

At moment I've been editing mine to only show OctoPrint instead of the clock in wide mode. Even though I removed a lot of the features I dont use the code is still huge due to the wifi manager and OTA coding etc, so wasnt able to get another api to work with it.

But I did find another clock that I was able to work another API into it as it doesnt have anything like a wifi manager or OTA. But it does have scrolling features

brianmiller1956 commented 3 years ago

Thank you victor, this looks interesting.

Sent from my iPad Pro

On 1 Feb 2021, at 17:02, victor7376 notifications@github.com wrote:

 Not sure if this will help you, but I've come across a clock that has the 'st, nd & rd' for the date numbers.

https://www.adrian-smith31.co.uk/blog/2020/04/dual-colour-animated-clock-using-16x32-bi-colour-matrix/

//then work out date 2 letter suffix - eg st, nd, rd, th etc char suffix[4][3]={ "st", "nd", "rd", "th" }; byte s = 3; if(date == 1 || date == 21 || date == 31) { s = 0; } else if (date == 2 || date == 22) { s = 1; } else if (date == 3 || date == 23) { s = 2; }

Hope it helps you in figuring out how to code it lol.

At moment I've been editing mine to only show OctoPrint instead of the clock in wide mode. Even though I removed a lot of the features I dont use the code is still huge due to the wifi manager and OTA coding etc, so wasnt able to get another api to work with it.

But I did find another clock that I was able to work another API into it as it doesnt have anything like a wifi manager or OTA. But it does have scrolling features

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

brianmiller1956 commented 3 years ago

Hi Victor I added this code yesterday and with much modification it is in testing, I did get changeover from 1st to 2nd last night, I had to use a slightly odd way of printing the suffix, it could be called ugly but it does work, just need to check it uses all four suffixes at the right time. Many thanks for the pointer.

Sent from my iPad Pro

On 1 Feb 2021, at 17:02, victor7376 notifications@github.com wrote:

 Not sure if this will help you, but I've come across a clock that has the 'st, nd & rd' for the date numbers.

https://www.adrian-smith31.co.uk/blog/2020/04/dual-colour-animated-clock-using-16x32-bi-colour-matrix/

//then work out date 2 letter suffix - eg st, nd, rd, th etc char suffix[4][3]={ "st", "nd", "rd", "th" }; byte s = 3; if(date == 1 || date == 21 || date == 31) { s = 0; } else if (date == 2 || date == 22) { s = 1; } else if (date == 3 || date == 23) { s = 2; }

Hope it helps you in figuring out how to code it lol.

At moment I've been editing mine to only show OctoPrint instead of the clock in wide mode. Even though I removed a lot of the features I dont use the code is still huge due to the wifi manager and OTA coding etc, so wasnt able to get another api to work with it.

But I did find another clock that I was able to work another API into it as it doesnt have anything like a wifi manager or OTA. But it does have scrolling features

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

victor7376 commented 3 years ago

Great to hear

victor7376 commented 3 years ago

I'm trying to get it to work myself at the moment, but the coding I'm trying isnt allowing my to do it.

Any chance you could post how yours is working please?

I'm trying the following: if (day() == "1" || "21" || "31") { msg += "st, "; }

Update: Never mind thing I solved my issue:

if (day() == 1 || day() == 21 || day() == 31) { msg += "st, "; } else if (day() == 2 || day() == 22) { msg += "nd, "; } else if (day() == 3 || day() == 23) { msg += "rd, "; } else { msg += "th, "; }

brianmiller1956 commented 3 years ago

Hi Victor, Yes I will email you later on today, it does work but adding the suffix print part of the code is “ugly” and I am sure someone will say that’s not the way to do it. Brian.

Sent from my iPad Pro

On 12 Mar 2021, at 11:46, victor7376 @.***> wrote:

 I'm trying to get it to work myself at the moment, but the coding I'm trying isnt allowing my to do it.

Any chance you could post how yours is working please?

I'm trying the following: if (day() == "1" || "21" || "31") { msg += "st, "; }

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

brianmiller1956 commented 3 years ago

String temperature = weatherClient.getTemp(0);//removed Rounded now shows negative temps String description = weatherClient.getDescription(0); description.toUpperCase(); char suffix[4][3]={ "st", "nd", "rd", "th" }; byte s = 3; if(day() == 1 || day() == 21 || day() == 31) { s = 0; } else if (day() == 2 || day() == 22) { s = 1; } else if (day() == 3 || day() == 23) { s = 2; } String msg; msg += " ";

  if (SHOW_DATE) {

    msg += TimeDB.getDayName() + ", " + day() + char (suffix[s][0]) +  char (suffix[s][1]) + "  "; //shows day name, number, added comma to day name and suffix to day number
    msg += TimeDB.getMonthName() + ", " + year() +":  ";//  moved day to previous line, added comma after month name, added year display and colon
  }

Hi Victor this is how the code looks, as I have said the mod to actually add the suffix on to the message is ugly but works, I liken it to the saying any aeroplane landing you can walk away from is a good landing. This has been working since Feb 1st.

Sent from Mail for Windows 10

From: victor7376 Sent: 12 March 2021 11:46 To: Qrome/marquee-scroller Cc: brianmiller1956; Author Subject: Re: [Qrome/marquee-scroller] £ sign does not display (#155)

I'm trying to get it to work myself at the moment, but the coding I'm trying isnt allowing my to do it. Any chance you could post how yours is working please? I'm trying the following: if (day() == "1" || "21" || "31") { msg += "st, "; } — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

victor7376 commented 3 years ago

cheers, I dont think you spotted or received the update when I edited the post, as I've got it working now and its very similar to what you've coded.

brianmiller1956 commented 3 years ago

Ok, how did you add the suffix print function to the day number, this is the bit I don’t like, but it works.

Sent from my iPad Pro

On 12 Mar 2021, at 13:43, victor7376 @.***> wrote:

 cheers, I dont think you spotted or received the update when I edited the post, as I've got it working now and its very similar to what you've coded.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

victor7376 commented 3 years ago

msg += TimeDB.getDayName() + ", " + day(); // Sort out the dates if you can. if (day() == 1 || day() == 21 || day() == 31) { msg += "st, "; } else if (day() == 2 || day() == 22) { msg += "nd, "; } else if (day() == 3 || day() == 23) { msg += "rd, "; } else { msg += "th, "; } msg += TimeDB.getMonthName() + ", " + year() +" :"; // moved day to previous line, added comma after month name, added year display and colon'

This is how I've got it to work. I was looking at how the printerclient was doing it and coded it in the virtually the same way. At first I tried just having the numbers but it didnt seem to like that so ended up with the above.

brianmiller1956 commented 3 years ago

Hi Victor, I have used your version as it is much better than mine! A further option would also be to change the suffix to “th, of “; and do the same for the three other suffixes so the date would show as, Monday, 15th, of March, 2021: Many thanks.

Sent from my iPad Pro

On 12 Mar 2021, at 14:09, victor7376 @.***> wrote:

 `msg += TimeDB.getDayName() + ", " + day(); // Sort out the dates if you can. if (day() == 1 || day() == 21 || day() == 31) { msg += "st, "; } else if (day() == 2 || day() == 22) { msg += "nd, "; } else if (day() == 3 || day() == 23) { msg += "rd, "; } else { msg += "th, "; }

msg += TimeDB.getMonthName() + ", " + year() +" :";  //  moved day to previous line, added comma after month name, added year display and colon

` This is how I've got it to work. I was looking at how the printerclient was doing it and coded it in the virtually the same way. At first I tried just having the numbers but it didnt seem to like that so ended up with the above.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

victor7376 commented 3 years ago

No problem, it was a learning experience for me. I’m still looking at adding new features into the scroller that one of qromes other project has that this doesn’t, but that’s for octoprint.

Also got mine scrolling when the next update is ;)

Neeraj-Ch commented 3 years ago

Can we also do a tweak to show °C symbol instead of only C shown as prefix of Temperature.

victor7376 commented 3 years ago

Can we also do a tweak to show °C symbol instead of only C shown as prefix of Temperature.

Do you mean for general temperature or printer? I’ll have a look but what you’ve got to remember is there’s only a certain amount of dots and it might come out as a square instead of a circle.

Neeraj-Ch commented 3 years ago

I am talking about general Temperature, which shows while scrolling.

victor7376 commented 3 years ago

I am talking about general Temperature, which shows while scrolling.

I’ll take a look right now, hopefully I can do something ;)

victor7376 commented 3 years ago

Ok I’ve just tried the degree symbol and it came up with unreadable dots, so might look into doing something else.

Neeraj-Ch commented 3 years ago

Thanks Victor. I'll try again at morning tomorrow, hope it works.

brianmiller1956 commented 3 years ago

Hi Victor just seen this, I added the degree symbol a long while ago, it came from another fork, will fire up the laptop

Sent from my iPad Pro

On 13 Mar 2021, at 17:31, victor7376 @.***> wrote:

 Ok I’ve just tried the degree symbol and it came up with unreadable dots, so might look into doing something else.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

brianmiller1956 commented 3 years ago

Hi Victor, this is how I added the degree symbol to the present temp and the hi/Lo just add +char(247) to look like the following.

if (SHOW_CITY) { msg += weatherClient.getCity(0) + ". ";//added full stop to place name } msg += temperature + char(247) + getTempSymbol() + " "; //added char(247) degree symbol

  //show high/low temperature, added space to Hi/Lo, Humidity, Barometer
  if (SHOW_HIGHLOW) {
    msg += "High/Low: " + weatherClient.getHigh(0) + "/" + weatherClient.getLow(0) + char(247) + getTempSymbol() + "  ";//added char(247) degree symbol
  }

Sent from Mail for Windows 10

From: victor7376 Sent: 13 March 2021 17:31 To: Qrome/marquee-scroller Cc: brianmiller1956; Author Subject: Re: [Qrome/marquee-scroller] £ sign does not display (#155)

Ok I’ve just tried the degree symbol and it came up with unreadable dots, so might look into doing something else. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

brianmiller1956 commented 3 years ago

Hi, This is the modification I found to add the degree symbol to the temp in both the present and hi/lo entries

if (SHOW_CITY) { msg += weatherClient.getCity(0) + ". ";//added full stop to place name } msg += temperature + char(247) + getTempSymbol() + " "; //added char(247) degree symbol

  //show high/low temperature, added space to Hi/Lo, Humidity, Barometer
  if (SHOW_HIGHLOW) {
    msg += "High/Low: " + weatherClient.getHigh(0) + "/" + weatherClient.getLow(0) + char(247) + getTempSymbol() + "  ";
  }

Sent from Mail for Windows 10

From: Neeraj-Ch Sent: 13 March 2021 17:45 To: Qrome/marquee-scroller Cc: brianmiller1956; Author Subject: Re: [Qrome/marquee-scroller] £ sign does not display (#155)

Thanks Victor. I'll try again at morning tomorrow, hope it works. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.