search

Qrome / marquee-scroller

Marquee Scroller Clock News Weather and More
https://www.thingiverse.com/thing:2867294
MIT License
328 stars 159 forks source link

HTTP.begin - outdate API syntax #207

Closed G6EJD closed 2 years ago

G6EJD commented 2 years ago

PiHoleClient.cpp:38:13: error: call to 'HTTPClient::begin' declared with attribute error: obsolete API, use ::begin(WiFiClient, url) 38 | http.begin(apiGetData);// get the result | ~~^~~~

needs to be:

WiFiClient client; http.begin(client, apiGetData);

Fix all other instances too.

Qrome commented 2 years ago

All depends on what core version you use.

G6EJD commented 2 years ago

Yes, just discovered that, downgraded to 2.7 and OK, suggest add a note in the readme, thanks all working now.

Qrome commented 2 years ago

Thanks, though 2.7 should work, the readme.md does call it out: image

brianmiller1956 commented 2 years ago

Sorry to but in, this does compile on v2.7.4 anything later and it does NOT compile, many thanks.

Sent from Mail for Windows

From: Qrome Sent: 25 October 2021 18:58 To: Qrome/marquee-scroller Cc: Subscribed Subject: Re: [Qrome/marquee-scroller] HTTP.begin - outdate API syntax (Issue#207)

Thanks, though 2.7 should work, the readme.md does call it out:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

G6EJD commented 2 years ago

Thank you, I missed the version in the readme, after a few minutes of running I noticed unreliable operation using 2.7.4 but 2.5.2. is reliable.