yuyichao
commented
10 years ago On Tue, Jul 22, 2014 at 2:00 AM, Maiya Liy Huff notifications@github.com wrote:
Not only have you not pushed critical fixes through to the official version (which should have been done via bugfix release the moment the bug with the glow was discovered), but you've broken the git version to where QtCurve does not even show up in the Application Appearance > Style menu of SystemSettings. Worse, titlebars are now broken, and the only way to use QtCurve currently is to set KDE to use GTK's theme, which does not work nearly as well as using QtCurve directly.
AFAIK, this should work as it always is and it is working here.
Furthermore, there remain countless unresolved and outright ignored issues here on Github. I loved QtCurve, and then you ruined it. I'll be waiting until someone worth their salt comes along, using 1.8.17, the last good version.
AFAIK, the regression in 1.8.18 is reverted in git master. (although not released, see below)
Also, with what you've been changing, you might want to consider a minor release instead of a bugfix release. When you break things, you don't make people think you've simply fixed a minor typo in text; you outright tell them that "Hey, this new version's a bit noticeably different than the last, so here's a minor release, because it would be irresponsible to publish it as a bugfix release."
I hate bashing on you over this because you're developing an open source project for free, and simply gifting your work to us. And I appreciate that. But please, do a good job with it; if you're going to haphazardly test things out, that's fine; but actually test them before publishing an official release. If you made a mistake in the
You are right here that I didn't tag a new release for the regression in 1.8.18 (delayed because of personal reasons but that is not an excuse).
I was planning to do a new release a week ago for the regression and some other fixes but I was travelling last week and have just come back last weekend. It will happen sometime soon (should be this week)
release, patch it and release a hotfix. Releases are not betas, and minor
releases are not bugfix releases. If you compile QtCurve on your computer after tweaking some things, and it doesn't work, like, at all; don't put it on Git yet! Find what went wrong! Fix it, and then upload to Git. It might be different if there were more contributors, but as the only one, you have to control the quality of your own work.
This is what I have always been doing. The reason that there's regression sometime is that I cannot conver all different option provided by qtcurve. (This is also why I was spliting some common routines out but that's another story)
And for goodness sakes, you've only got 42 reports of bugs. At least reply to us more often than not; ignoring us just makes us resent both you and the project, which is a shame, because QtCurve is really cool.
I wish you luck, and I'm always hoping every time that QtCurve is updated that it's even better than the last time. But until then, I'm going back to the last truly stable version (1.8.17).
I apologize for the length of this rant. I'm going to try to take some screenshots of what it looks like on my computer, and upload them for you. Perhaps the issues stem from your attempts to tweak the functioning of AA on Qt5?
If you have some screenshot that show regression after that last commit on Qt5, it would be nice. The change looks OK for the one case I was looking at but it was used in a lot of different cases and I am not confident yet that it will not break other places horribly.
— Reply to this email directly or view it on GitHub https://github.com/QtCurve/qtcurve/issues/76.
MilesBHuff
Fixed in update.