QtExcel / QXlsx

Excel file(*.xlsx) reader/writer library using Qt 5 or 6. Descendant of QtXlsxWriter.
https://qtexcel.github.io/QXlsx/
MIT License
1.13k stars 352 forks source link

Improve exception safety with smart pointers #265

Open elfring opened 1 year ago

elfring commented 1 year ago

Would you like to wrap any pointers with the class template “std::unique_ptr”?

Update candidates:

dantti commented 1 year ago

std::make_shared brings some perf improvement, I'd rather just remove the if(ptr) as delete nullptr is harmless; unique_ptr doesn't always play well with forwarded private classes