search

QuEraComputing / Bloqade.jl

Package for the quantum computation and quantum simulation based on the neutral-atom architecture.
https://queracomputing.github.io/Bloqade.jl/dev/
Other
183 stars 36 forks source link

[Feature Request] CompatHelper #375

Closed Roger-luo closed 1 year ago

Roger-luo commented 2 years ago

need to setup CompatHelper for this repo. I need to check how subdir works for CompatHelper.

manulpatel commented 1 year ago

Hello @Roger-luo! I would be happy to work on this. Could you please assign me?

ACE07-Sev commented 1 year ago

I'd like to work on this as well. Can you kindly assign me to it?

Roger-luo commented 1 year ago

@ACE07-Sev there is already a PR trying to fix this (but it is not working) if you also want to work on this you can submit a new PR, but I'd encourage you to take a different issue

manulpatel commented 1 year ago

@Roger-luo I have updated my PR to also include subdirectories inside lib to scan in CompatHelper. Could you please review it?

Roger-luo commented 1 year ago

@manulpatel I don't think it works https://github.com/QuEraComputing/Bloqade.jl/actions/runs/5127411880/jobs/9223001629

manulpatel commented 1 year ago

@Roger-luo Yes I have made changes and opened up a new PR. I hope this should work. It seemed prior had issues with "" quotes in subdirs.

manulpatel commented 1 year ago

@Roger-luo. I have opened a fresh PR, which setups CompatHelper only for main repo i.e. at top dir. For subdirs I tred to follow [this](url) but there are errors when scannnig inside lib dir. Your insights on this would be very helpful.

natestemen commented 1 year ago

@manulpatel reminder that if you get this issue closed by June 20th, you'll be eligible for the unitaryHACK bounty!

manulpatel commented 1 year ago

Thanks @natestemen for reminding! Actually I am stuck on this and not able to pass the CI tests for my changes.

manulpatel commented 1 year ago

@Roger-luo Could you please assign me the issue and then close it? As this would allow Unitary Hack bots to discover this issue. @natestemen The PR for this issue is successfully merged as per the deadline of 20 June AoE. Kindly consider me in the Unitary Hack 2023 for this issue.

Roger-luo commented 1 year ago

I just did that I'm not sure if this works or not, please let me know if it doesn't.