search

QuEraComputing / bloqade-python

QuEra's Neutral Atom SDK for Analog QPUs
https://bloqade.quera.com/
Other
54 stars 14 forks source link

Analysis functions ownership #251

Open jon-wurtz opened 1 year ago

jon-wurtz commented 1 year ago

Should analysis functions be owned by job outputs, eg

emu_job.rydberg_densities()

or by a specific sub-module

bloqade.analysis.rydberg_densities(emu_job)
Roger-luo commented 1 year ago

I think the consistent design is the former as we do not want users to look for which module to use, there is only one module bloqade that needs to know in most of cases for a user, which is the current design. On the one hand, we can provide some more bare bone implementations within a module for those more hardcore users like what we did for the IR.

jon-wurtz commented 1 year ago

https://github.com/Happy-Diode/bloqade-python/pull/335 Because I needed to do it sometime