search

QuState / PhastFT

A high-performance, "quantum-inspired" Fast Fourier Transform (FFT) library written in pure and safe Rust.
Apache License 2.0
193 stars 8 forks source link

Implmentation of R2C FFT #26

Open smu160 opened 2 months ago

smu160 commented 2 months ago

@calebzulawski Draft for #23

smu160 commented 1 month ago

Hi @calebzulawski,

We now have a working version of R2C FFT. This version is clearly sub-optimal as I made correctness the main priority. I'll measure and tune the implementation for now. In the interim, I recall you mentioned, inter alia, ideas about the public API and the use of traits.

I'm curious to hear your thoughts. Thank you!

Best, Saveliy

calebzulawski commented 1 month ago

Looks good! I think starting with correctness is the way to go. Regarding traits, I think I will probably submit a PR in the future after this has been merged.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 99.53704% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@2df2f00). Learn more about missing BASE report.

Files Patch % Lines
utilities/src/lib.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #26 +/- ## ======================================= Coverage ? 99.40% ======================================= Files ? 9 Lines ? 1007 Branches ? 0 ======================================= Hits ? 1001 Misses ? 6 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

smu160 commented 1 month ago

Looks good! I think starting with correctness is the way to go. Regarding traits, I think I will probably submit a PR in the future after this has been merged.

Hi @calebzulawski,

I believe we're finally at a point where we can scrutinize the implementation, make necessary changes, and merge. Please feel free to point out any deficiencies and I can work on fixing them.

Thank you!!