search

QuState / PhastFT

A high-performance, "quantum-inspired" Fast Fourier Transform (FFT) library written in pure and safe Rust.
Apache License 2.0
193 stars 8 forks source link

Fixes inverse FFT ouput order issue #29

Closed smu160 closed 2 months ago

smu160 commented 2 months ago

This PR should address issue #24.

TL;DR

There's a bug in the original implementation of reverse (i.e., inverse FFT). I've yet to figure out a direct fix. Nevertheless, one can compute the inverse FFT using the forward FFT [1].

Inverse_FFT_Figure4[2]

Note this is meant to be a stop-gap solution until I get to the bottom of the underlying issue.

References

[1] [2]

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.15%. Comparing base (48a8d15) to head (aaa6a89).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #29 +/- ## ========================================== + Coverage 96.99% 97.15% +0.15% ========================================== Files 7 7 Lines 698 737 +39 ========================================== + Hits 677 716 +39 Misses 21 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.