Closed wvlothuizen closed 3 years ago
Also, where did src/CMakeLists.txt
come from? You should be building from the root directory (which doesn't work right now as evidenced by CI because libqasm was reverted to an ancient version).
I know by the way that normally all subdirectories have CMakeLists in them, it just didn't make sense to me for this particular project structure. In any case, if you think that should be revised, it should be through a different PR.
@Hans: I did observe the DAG error once, and just quickly inserted a FIXME to allow reproducing. And I replaced the warning by Fatal, because it does not seem to make sense to continue. It would be better to make a Github issue on this, and I will after my laptop has recovered from sudden death (which may very well take a few days). Still, I don't think the actual problem is caused by this PR, somehow one of the PycQED test cases triggered this behaviour (and may still do so).
@Jeroen: I'll clean up the mess once my laptop works again, I did see a libqasm conflict and performed a "git submodule update", but without the "--recursive". By the way, great that we now have CI on PRs. I'll request a review once I remove the "WIP" status of this PR.
Tests temporarily disabled:
[x] test_cc.cc::test_qi_example
[x] codegen_cc.cc : " verify dimensions"
@jvansomeren: I filed issue #363 regarding the scheduler that seems to block this PR
ready for merge, note that I'll continue to properly call scheduler
The libqasm submodule also got downgraded, causing literally all builds to fail. Please run
and commit.
In the future, when git says a submodule has "new commits" after a merge (or pull), run
git submodule update --recursive
. git is extremely stupid about this; the "new commits" it's referring to actually means "old commit" in this case, because the merge/pull doesn't update your working tree automatically for submodules like it does for files. So if yougit add
it to your commit you force it back to the previous state from your working tree.git submodule update --recursive
aligns your working tree with the merged state. Why git doesn't do this automatically I'll never know, but googling I did find this to automate what IMO should be default behavior.