search

QuTech-Delft / OpenQL

OpenQL: A Portable Quantum Programming Framework for Quantum Accelerators. https://dl.acm.org/doi/10.1145/3474222
https://openql.readthedocs.io
Other
99 stars 44 forks source link

Feedback support for CC backend #370

Closed wvlothuizen closed 3 years ago

wvlothuizen commented 3 years ago

@jvansomeren @jvanstraten : Ready for review in my opinion, merged with develop and all checks pass

wvlothuizen commented 3 years ago

I'll have a look at my whitespace settings: I recently switched to CLion which may have upset things.

I'm fine with you making the edits you propose, shall we use a separate PR for that so I can have a glance at the changes?

jvanstraten commented 3 years ago

Sure, I'll do a pass over it on Monday and PR it into DiCarloLab-Delft:feature/cc/feedback.

wvlothuizen commented 3 years ago

@jvansomeren @jvanstraten :

do you think can we merge, the refactoring by Jeroen is in place, and the tests only seem to fail because the Windows build fails to obtain Swig/Bion

jvanstraten commented 3 years ago

Oops, I forgot about that. I restarted CI to see if it was a temporary remote issue and fixes itself, but if not I'll just override it/merge anyway and make a note of having to fix it on develop.