QuTech-Delft / OpenQL

OpenQL: A Portable Quantum Programming Framework for Quantum Accelerators. https://dl.acm.org/doi/10.1145/3474222
https://openql.readthedocs.io
Other
100 stars 45 forks source link

Remove sweep points functionality #458

Closed pablolh closed 2 years ago

pablolh commented 2 years ago
pablolh commented 2 years ago

@wvlothuizen This removes the deprecated sweep points feature, as per your email from Friday.

wvlothuizen commented 2 years ago

OK! I approved running CI (which must be done once for new users), and see some failures.

We have a sort of convention to prefix the PR title with "[WIP]" until its ready for review (because you need write access to set it to 'Draft' o GitHub), and then ask for a review from ~2 people when done

pablolh commented 2 years ago

Sorry for the failed CI, it should be fixed now. I'm relatively unfamiliar with Github's interface, I don't see where I can add reviewers or assignees. CI still doesn't seem to have started on the 2nd push.

pablolh commented 2 years ago

Thanks, updated the changelog.

pablolh commented 2 years ago

I don't seem to have the rights to merge this either. I don't see a "Merge" button. @jvansomeren you could also take a look if you want