QuTech-Delft / QMI

Quantum Measurement Infrastructure
Other
14 stars 4 forks source link

Error in scheduled weekly tests for py313 #118

Closed heevasti closed 5 days ago

heevasti commented 1 week ago

Description

The scheduled weekly pipelines gave an error on the Python 3.13 unit-tests. The py-xdrlib did not get correctly installed. The problem is likely in the if statement:

      - name: Run unit tests and generate report
        if: always()
        run: |
          if [[ ${{ matrix.python-version }} == "3.13" ]]; \
            then pip install https://github.com/da4089/py-xdrlib/archive/refs/heads/main.zip; fi
          pip install .
          pip install unittest-xml-reporting
          python -m xmlrunner --output-file testresults.xml discover --start-directory=tests --pattern="test_*.py"

It should get fixed by moving the statement in its owe section, something like this:

      - name: Check py-xdrlib installation for Python 3.13
        if: [[ ${{ matrix.python-version }} == "3.13" ]]
        run:
            pip install https://github.com/da4089/py-xdrlib/archive/refs/heads/main.zip

      - name: Run unit tests and generate report
        if: always()
        run:
          ...

ps. We could possibly wait for the py-xdrlib 4.0.2 release, so that we can do simply pip install py-xdrlib instead of providing the while Github hubbub.

Affected components

CI weekly scheduled pipelines

Modules to be modified

Documentation

No need to edit CHANGELOG.md just for this.