QuTech-Delft / QMI

Quantum Measurement Infrastructure
Other
14 stars 4 forks source link

Newport single axis motion controller relative move with negative values #63

Closed rbudhrani closed 9 months ago

rbudhrani commented 10 months ago

Describe the bug The Newport single axis motion controller has a bug in its relative move command. it does not allow for negative displacement. It checks if the given displacement is less than the allowed minimum incremental motion of the actuator and fails because a negative displacement will always be lower than that value. Instead it must check against the absolute value of the provided displacement. https://github.com/QuTech-Delft/QMI/blob/4ec147fbb14203c3d8674f35b78be85cbd58bbf6/qmi/instruments/newport/single_axis_motion_controller.py#L490

To Reproduce

Expected behavior

Screenshots

Operating System (please complete the following information):

Additional context