search

QuTech-Delft / quantuminspire

Quantum Inspire SDK
Apache License 2.0
65 stars 27 forks source link

New CalibrationViewer helper object for nice printing of backend calibration data #120

Closed codecrap closed 5 months ago

codecrap commented 2 years ago

This is a proposal for a CalibrationViewer helper object to nicely handle and print backend calibration data. It uses rich printing but falls back to the builtin print if not available. I will add more tests and further refine the class if it is in principle okay to include this helper object in the main repo.

An example of its use is currently available in the examples repo (updated version here).

codecrap commented 2 years ago

The pipeline is failing because it tries to run a notebook that requires authentication, which it doesn't receive and thus the build times out. The same test does not seem to be a problem for a test PR #121 . Can you help out with this issue @QFer ?

QFer commented 2 years ago

@codecrap The reason is that pull requests sent from forked repositories do not have access to encrypted authentication secrets needed for running the tests on quantum inspire backend. A possible solution is to disable these example runs for pull requests.

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 50b8d9a8932fa459084b22f8ad204f97f53b0c84 on codecrap:feat/calibration_viewer into 0c5a68ed854aeea8eda183be207daed3176de6bf on QuTech-Delft:dev.

QFer commented 2 years ago

@codecrap I made a change so the pull request coming from a fork is not running the examples. While reviewing and before merging we will run the examples and check correctness. Please add unit test to coverage 100% and I guess your (out-of-date) branch needs a rebase or merge.