search

QuTech-Delft / quantuminspire

Quantum Inspire SDK
Apache License 2.0
65 stars 27 forks source link

[DEM-737] making memory available in Qiskit #24

Closed QFer closed 5 years ago

QFer commented 5 years ago

[DEM]-737 making memory available actually means that the ExperimentResultData of an qiskit experiment returned by the SDK backend includes the raw results from the QI simulator in the 'memory' item. The raw results are converted to the classical bit representation according to the measure statements in the circuit. The 'memory' attribute in the backend configuration is set to True to indicate that we now support this memory data. The jira ticket refers to pp 18 of https://qutech-sd.atlassian.net/wiki/pages/viewpageattachments.action?pageId=783810644) I furthermore did some small changes as spelling (Qiskit is the official spelling as cQASM). Resolved some PEP8 warnings.

When there is no memory data the memory argument of ExperimentResultData may not be referenced in any way.

I refactored __convert_histogram to make use of the new function __qubit_2_classical_hex, which is also used by the new function to get the memory_data in the right format.

The unittests are adjusted with this new field. I added one unittest for the number_of_shots = 1 case, because this is a special case. The backend returns no raw_data (empty list), so no memory_data is generated.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 21dfe04920775cde3f8cb6644c56ac7c8bfc131b on feature/DEM-737/Qiskit_memory into f6d01cf4efcb3f89f9dfcf5f5c50931ebf432503 on dev.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling e3dd7d5fc715d052782ca4f147c09f5b4195c965 on feature/DEM-737/Qiskit_memory into 1d1a9c5a0d40e86d67f7d3f350d539aae1a843a3 on dev.

QFer commented 5 years ago

qSaevar, I rebased to dev and had to do a git push --force