[DEM-959] Validate usage of classical bits after measurement

QuTech-Delft / quantuminspire

Quantum Inspire SDK

Apache License 2.0

65 stars 27 forks source link

[DEM-959] Validate usage of classical bits after measurement #53

Closed QFer closed 5 years ago

QFer commented 5 years ago

Adjusted validation method in qiskit backend_qx (__validate_no_usage_after_measure)
- docstring was not correct
- added a check that measured memory bits are not used later on as a condition in a binary controlled gate. Because in FSP simulation measurements are not done until the end, so we can't make usage of measured classical bits to influence the outcome of a circuit yet.
Unittests added

coveralls commented 5 years ago

Coverage remained the same at 100.0% when pulling d0d0b5e1ec45698fd149ece5ec90703d30f32f58 on feature/dem959/tighten_check_fsp into 22a4377557b8e4f76166a42ddd82e22eb5c17257 on dev.

QFer commented 5 years ago

I tested the notebooks also. They were good.