QuadFlask / colorpicker

🍭color picker for android
1.22k stars 219 forks source link

"Squash listener exceptions" - wtf? #74

Closed ELO8C8 closed 7 years ago

ELO8C8 commented 7 years ago

In ColorPickerView's callOnColorChangedListeners method:

try { listener.onColorChanged(newColor); } catch (Exception e) { //Squash individual listener exceptions }

Why do you do this? This makes it a pain to use your library because you just hide the exceptions. If I have an exception I want my app to crash so I can find the cause. I have found other empty catches in this library but until it catches exceptions in the library only it doesn't bother me that much. But this one is 'funky'.

QuadFlask commented 7 years ago

thanks! I will fix this asap.