QuadFlask / colorpicker

🍭color picker for android
1.22k stars 219 forks source link

Refactor - ColorCircle getHsvWithLightness #75

Closed ELO8C8 closed 6 years ago

ELO8C8 commented 7 years ago

getHsvWithLightness function is unnecessary because there is a pure method just for this in Utils.

Instead of: color = Color.HSVToColor(currentColorCircle.getHsvWithLightness(this.lightness));

you could simply use:

color = Utils.colorAtLightness(currentColorCircle.getColor(), this.lightness)

This way you won't have a duplicated method.