Quaffel / get-me-drunk-efficiently

Webservice providing cocktail recommendations based on how drunk you want to be
4 stars 0 forks source link

Use of Wikimedia imagery #34

Closed Quaffel closed 3 years ago

Quaffel commented 3 years ago

The documentation claims that the Wikimedia API is used to provide images of the cocktails. At present, this isn't the case. Is this something we still want to add to our MVP or should we just remove the corresponding section?

Jonasdoubleyou commented 3 years ago

Do we have the URL already? How long would it take to provide it? Frontend is 20mins

Quaffel commented 3 years ago

Images of entities are referenced using the standardized "image" property. Adding the following line (and the additional query parameter) to the SPARQL query should thus be sufficient to retrieve the URL.

OPTIONAL { ?cocktail wdt:P18 ?imageUrl. }
Jonasdoubleyou commented 3 years ago

Then I'd say this is possible today. Also it would be quite fun for the showcase